Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9319 )
Change subject: KUDU-2291 (part 6) stacks: use libunwind directly for stack tracing ...................................................................... Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9319/7/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9319/7/src/kudu/util/debug-util.cc@544 PS7, Line 544: skip_frames++; // Do not include the "Collect" frame > I believe it did, didn't it? Ah, I just looked and the other calls are no-arg, contrary to what I thought. Thanks for checking. -- To view, visit http://gerrit.cloudera.org:8080/9319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a53e55d7c4e7ee50bcac5b1e81267df56383634 Gerrit-Change-Number: 9319 Gerrit-PatchSet: 8 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 19:24:45 +0000 Gerrit-HasComments: Yes
