Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9382 )
Change subject: Fix move constructors to be noexcept ...................................................................... Patch Set 1: That's a nice find! What about updating the following places as well: cfile/block_cache.h (class PendingEntry) util/cow_object.h (class CowLock) Or those can throw? -- To view, visit http://gerrit.cloudera.org:8080/9382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd7487766be3261e3506ff9613a5d733013018b0 Gerrit-Change-Number: 9382 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 21 Feb 2018 20:33:40 +0000 Gerrit-HasComments: No
