Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9365 )
Change subject: KUDU-721: [Flume] Add DECIMAL type support ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9365/2/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java File java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java: http://gerrit.cloudera.org:8080/#/c/9365/2/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java@154 PS2, Line 154: 9, 1 > what would happen if the decimal scale and precision didn't match between a It would coerce that value if possible and fail if it can't coerce without rounding. In PartialRow.addDecimal, DecimalUtil.coerce is called which handles this. In TestPartialRow testAddInvalidPrecisionDecimal, testAddInvalidScaleDecimal, testAddInvalidCoercedScaleDecimal, and testAddCoercedScaleAndPrecisionDecimal verify that behavior. -- To view, visit http://gerrit.cloudera.org:8080/9365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc02d683dd1bce2cc0de255e4d072436b6c0163a Gerrit-Change-Number: 9365 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Wed, 21 Feb 2018 21:04:42 +0000 Gerrit-HasComments: Yes
