Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9281
to look at the new patch set (#2).
Change subject: fs: clarify error message at startup
......................................................................
fs: clarify error message at startup
Currently the error messages you get when you start a Kudu instance
without specifying all the expected directories is:
I0205 09:26:39.961467 25499 server_base.cc:229] Could not load existing FS
layout: Not found: /data/01/kudu/data/instance: No such file or directory
(error 2)
I0205 09:26:39.961493 25499 server_base.cc:230] Creating new FS layout
F0205 09:26:39.963004 25499 tablet_server_main.cc:80] Check failed: _s.ok() Bad
status: Already present: Could not create new FS layout: unable to create file
system roots: FSManager root is not empty. See
https://kudu.apache.org/releases/1.7.0/docs/troubleshooting.html:
/data/01/kudu/wal
This can be misleading for users, who might think, "Well if it's not
starting because this path isn't empty, I'll just delete the contents of
that path!" This would be a terrible senario, as such actions could
easily lead to data loss. This patch attempts to make it more obvious
that Kudu may already exist in some (possibly incomplete) form at the
specified locations, and that if the user truly wants to change directories,
they should run the appropriate tools.
Now, starting Kudu will log.
I0221 18:36:14.403893 35003 server_base.cc:431] Could not load existing FS
layout: Not found: /data/8/awong/kudu/build/release/wal/instance: No such file
or directory (error 2)
I0221 18:36:14.403903 35003 server_base.cc:432] Attempting to create new FS
layout instead
I0221 18:36:14.404762 35003 server_base.cc:438] To start Kudu with a different
FS layout, the `kudu fs update_dirs` tool must be run first
F0221 18:36:14.404858 35003 tablet_server_main.cc:80] Check failed: _s.ok() Bad
status: Already present: FS layout already exists; not overwriting existing
layout. See https://kudu.apache.org/releases/1.7.0/docs/troubleshooting.html:
unable to create file system roots: FSManager roots already exist:
/data/01/kudu/wal,/data/02/kudu/data,/data/03/kudu/data
Change-Id: I72294036e9aa78b285803d5d78b685cf444d9662
---
M docs/troubleshooting.adoc
M src/kudu/fs/fs_manager.cc
M src/kudu/server/server_base.cc
3 files changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/9281/2
--
To view, visit http://gerrit.cloudera.org:8080/9281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72294036e9aa78b285803d5d78b685cf444d9662
Gerrit-Change-Number: 9281
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
