Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9398 )

Change subject: java: provide our own preferred cipher suite list
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9398/2/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java:

http://gerrit.cloudera.org:8080/#/c/9398/2/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@520
PS2, Line 520:     engine.setEnabledCipherSuites(toEnable.toArray(new 
String[0]));
Maybe add an assert that the toEnable list isn't empty, or is that sufficiently 
unlikely?



--
To view, visit http://gerrit.cloudera.org:8080/9398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b2853dfd8d330bdf003924a5574fde865f54249
Gerrit-Change-Number: 9398
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 22 Feb 2018 19:02:26 +0000
Gerrit-HasComments: Yes

Reply via email to