Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9278 )

Change subject: tools: add more detail about unsafe_change_config
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc
File src/kudu/tools/tool_action_remote_replica.cc:

http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@437
PS2, Line 437: in cases where
when


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@437
PS2, Line 437: a tablet cannot "
             :                         "make progress with its current Raft 
configuration, "
             :                         "and a config change is necessary
Howabout "a config change is necessary because a tablet cannot make progress 
with its current Raft configuration"


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@439
PS2, Line 439: as a means to "
             :                         "follower eviction
Do you mean to evict followers when a majority is unavailable?


http://gerrit.cloudera.org:8080/#/c/9278/2/src/kudu/tools/tool_action_remote_replica.cc@442
PS2, Line 442: on that "
             :                         "replica
Redundant.



--
To view, visit http://gerrit.cloudera.org:8080/9278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If389f9fec4926b798c9885dac17b4de136644239
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:04:01 +0000
Gerrit-HasComments: Yes

Reply via email to