Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9280 )

Change subject: util: fix logged Kudu URL
......................................................................


Patch Set 3:

(2 comments)

> Patch Set 3:
>
> (2 comments)
>
> > This is only an issue in development while working on unreleased
>  > code right? Even with this fix there are no docs deployed to for
>  > that version yet right?
>
> Also, if we move to publishing the website from master, say, nightly (and I 
> think we should), don't we want to include the -SNAPSHOT?

It's not just for dev builds. What prompted the change was that I saw a 
production cluster point to http://.../1.7.0-cdh5.12/docs

http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/version_info.cc
File src/kudu/util/version_info.cc:

http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/version_info.cc@25
PS3, Line 25: #include <regex.h>
> C++11 has regex support now! I wrote up a quick example of matching version
I was basing the implementation on that in rpc/sasl_common.cc. A comment there 
mentioned it's broken in older versions of libstdcxx? Will look into it more.


http://gerrit.cloudera.org:8080/#/c/9280/3/src/kudu/util/version_info.cc@49
PS3, Line 49: "\\([[:digit:]]\\+\\.[[:digit:]]\\+\\.[[:digit:]]\\+\\)-.*"
> This regex doesn't look right to me. Don't we want
I agree, I'm surprised it needed this much escaping, but in test, this is what 
worked.



--
To view, visit http://gerrit.cloudera.org:8080/9280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:04:45 +0000
Gerrit-HasComments: Yes

Reply via email to