David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9397 )

Change subject: Don't perform compactions when clean time has not been advanced
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9397/2/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:

http://gerrit.cloudera.org:8080/#/c/9397/2/src/kudu/tablet/tablet.cc@1563
PS2, Line 1563:     LOG_WITH_PREFIX(WARNING) << "Can't schedule compaction. 
Clean time has not been advanced "
> Do we risk flooding the logs with this error when we hit this case? Seems i
I can change this to log every n, sure. not sure it would be so bad though, 
since it would only run once a sec or so and would log this only until stuff 
was replicated.



--
To view, visit http://gerrit.cloudera.org:8080/9397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74abdf7d806efc4239dc9cff4a5da28621d331a
Gerrit-Change-Number: 9397
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 21:54:37 +0000
Gerrit-HasComments: Yes

Reply via email to