Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9328 )

Change subject: rw_semaphore: dont include debug-util.h when not necessary
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9328/6/src/kudu/util/rw_semaphore.h
File src/kudu/util/rw_semaphore.h:

http://gerrit.cloudera.org:8080/#/c/9328/6/src/kudu/util/rw_semaphore.h@54
PS6, Line 54: //
            : // In order to support easier debugging of leaked locks, this 
class can track
            : // the stack trace of the last thread to lock it in write mode. 
To do so,
            : // uncomment the following define:
            : //   #define RW_SEMAPHORE_TRACK_HOLDER 1
> this is out of order from the define above and wouldn't actually work this
Done



--
To view, visit http://gerrit.cloudera.org:8080/9328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900
Gerrit-Change-Number: 9328
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 01:24:41 +0000
Gerrit-HasComments: Yes

Reply via email to