Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9409 )

Change subject: KUDU-2291 (part 8): fix a TSAN issue with libunwind 
initialization
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9409/1/src/kudu/util/debug-util.cc
File src/kudu/util/debug-util.cc:

http://gerrit.cloudera.org:8080/#/c/9409/1/src/kudu/util/debug-util.cc@522
PS1, Line 522: void PrimeLibunwind() {
nit: static void


http://gerrit.cloudera.org:8080/#/c/9409/1/src/kudu/util/debug-util.cc@523
PS1, Line 523: #ifdef __linux__
nit: because the only call is inside an #ifdef __linux__ this whole function 
can be inside one as well



--
To view, visit http://gerrit.cloudera.org:8080/9409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I522b6553e9cb9a30d7106ff55ad119f7df1f949c
Gerrit-Change-Number: 9409
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:25:39 +0000
Gerrit-HasComments: Yes

Reply via email to