Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9388 )
Change subject: [java] fix the regression test for KUDU-2267/KUDU-2319 ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@9 PS1, Line 9: is was ? http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@10 PS1, Line 10: token authn token http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@11 PS1, Line 11: is not construct correctly was not correct. http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@12 PS1, Line 12: fixs fixes http://gerrit.cloudera.org:8080/#/c/9388/1//COMMIT_MSG@13 PS1, Line 13: Please add: This is a follow-up for 0f0e42144a0d37f57394b373eb75eeb18bc28174. http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java: http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java@163 PS1, Line 163: KuduRpc<?> parentRpc, : long defaultTimeoutMs, : Connection.CredentialsPolicy credentialsPolicy) { nit: padding http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@83 PS1, Line 83: , . http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@83 PS1, Line 83: a A Also, for better readability, add an empty line between the first sentence and the rest of the description. http://gerrit.cloudera.org:8080/#/c/9388/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@87 PS1, Line 87: @Ignore If you base this a top of https://gerrit.cloudera.org/c/9373/, you can enable this test and verify that it passes. -- To view, visit http://gerrit.cloudera.org:8080/9388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e827586fe549f6a0c927ce8a4f8eca954bfe690 Gerrit-Change-Number: 9388 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 23 Feb 2018 05:55:12 +0000 Gerrit-HasComments: Yes
