Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9440 )

Change subject: KUDU-2312: Scan predicate application ordering is 
non-deterministic
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9440/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9440/1//COMMIT_MSG@10
PS1, Line 10: orders by selectivity (as before), but breaks ties by column 
index.
do you think determinism should be independent of the order in which the 
predicates are specified? ie should we leave it open for Impala to do things 
like order the predicates based on their selectivity estimates? I _think_ we 
maintain the order that the client specified all the way through, so using a 
std::stable_sort might be preferable to breaking ties by column index? It would 
still be deterministic, just client-specified.


http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc
File src/kudu/common/generic_iterators-test.cc:

http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc@402
PS1, Line 402: CHECK
ASSERT_TRUE?


http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc@416
PS1, Line 416: CHECK
same



--
To view, visit http://gerrit.cloudera.org:8080/9440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Gerrit-Change-Number: 9440
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Sat, 24 Feb 2018 01:29:05 +0000
Gerrit-HasComments: Yes

Reply via email to