Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9476

to review the following change.


Change subject: build: only use -fPIC when absolutely necessary
......................................................................

build: only use -fPIC when absolutely necessary

In general, position independent code is only needed when building shared
objects, but we also need it when KUDU_EXPORTED_CLIENT=1, because that's a
mixed static/shared build.

We'll continue to build thirdparty dependencies with -fPIC unconditionally,
however, because maintaining two trees (one with -fPIC, one without) would
be expensive and annoying.

Change-Id: I9e5c5b2d6e973a43e042709158e2d42f75c3739c
---
M CMakeLists.txt
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/9476/1
--
To view, visit http://gerrit.cloudera.org:8080/9476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e5c5b2d6e973a43e042709158e2d42f75c3739c
Gerrit-Change-Number: 9476
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to