Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9472 )

Change subject: build: use thin static libraries on Linux
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9472/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9472/1//COMMIT_MSG@7
PS1, Line 7: build: use thin static libraries on Linux
Neat trick; how did you discover it?


http://gerrit.cloudera.org:8080/#/c/9472/1//COMMIT_MSG@14
PS1, Line 14: 40% faster
Out of curiosity, how does this compare to a shared object build?


http://gerrit.cloudera.org:8080/#/c/9472/1/CMakeLists.txt
File CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/9472/1/CMakeLists.txt@1158
PS1, Line 1158: endif ()
$ git grep "endif (" | wc -l
17
$ git grep "endif(" | wc -l
149


http://gerrit.cloudera.org:8080/#/c/9472/1/CMakeLists.txt@1159
PS1, Line 1159:
Nit: extra empty line here.



--
To view, visit http://gerrit.cloudera.org:8080/9472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If662cea380e06eaddf45e52617e38e55e4613773
Gerrit-Change-Number: 9472
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 03 Mar 2018 00:29:19 +0000
Gerrit-HasComments: Yes

Reply via email to