Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9470 )
Change subject: build: enable sharding within cmake/ctest ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9470/4/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/9470/4/build-support/dist_test.py@50 PS4, Line 50: agood a good http://gerrit.cloudera.org:8080/#/c/9470/4/build-support/dist_test.py@165 PS4, Line 165: cwd=rel_to_abs("build/latest") This is new; why is it needed? http://gerrit.cloudera.org:8080/#/c/9470/4/build-support/dist_test.py@470 PS4, Line 470: with the --tests-regex Nit: "with --tests-regex above" or maybe "with the --tests-regex option above". http://gerrit.cloudera.org:8080/#/c/9470/4/build-support/dist_test.py@492 PS4, Line 492: def add_loop_test_subparser(subparsers): Should this mention that 'loop' is deprecated? Alternatively, if you're willing to eat the disruption of changing 'run-all' to 'run', perhaps you'd be willing to reduce 'loop' into a warning that instructs people to use 'run' instead of 'loop'? -- To view, visit http://gerrit.cloudera.org:8080/9470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20ddbdd73a64fda3fe32fca98ee541aa4cead4b3 Gerrit-Change-Number: 9470 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sun, 04 Mar 2018 16:51:00 +0000 Gerrit-HasComments: Yes
