Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9491 )
Change subject: [python] Ignore pytest cache and environment files ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore File python/.gitignore: http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@31 PS1, Line 31: .pytest_cache/ > What tool generates these? Can't say I've seen them when I tested Python ch I ran `python setup.py test` and this was generated. It could definitely be a situation where I am doing something in a "non standard" way. I am far from a python expert and it doesn't look like we have any development oriented docs around building and testing the python client. I will look to add some, but will need so review from someone more educated on python than me. http://gerrit.cloudera.org:8080/#/c/9491/1/python/.gitignore@49 PS1, Line 49: # Environments > Hmm, how do these get created? In my experience, you run "virtualenv foo" a When working with PyCharm (the Jetbrains IDE) the venv directory can be created. However I pulled in the others from githubs gitignore project, expecting it wasn't totally standard. (https://github.com/github/gitignore/blob/master/Python.gitignore) -- To view, visit http://gerrit.cloudera.org:8080/9491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77fd8fad9ca0029778dda524d7aae4a339f230d Gerrit-Change-Number: 9491 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 17:47:23 +0000 Gerrit-HasComments: Yes
