Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9462 )
Change subject: Make metrics name matching case-insensitive ...................................................................... Patch Set 2: > Some metrics have mixed case names, e.g. > "handler_latency_kudu_tserver_TabletCopyService_BeginTabletCopySession". > While working on an issue with Mike recently, we wanted to look at all > tablet-copy-related metrics, so we hit /metrics?metrics=copy and were > surprised to see the above metric missing. Gotcha. Could you include that use case in the commit message, so it's more clear what sort of new functionality is enabled by the commit? -- To view, visit http://gerrit.cloudera.org:8080/9462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49d76f969873c532e7cd297bee6fde13c98c68e7 Gerrit-Change-Number: 9462 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 00:19:45 +0000 Gerrit-HasComments: No