David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9521 )
Change subject: env: generalize resource limits and add RLIMIT_NPROC support ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env-test.cc@675 PS1, Line 675: KUDU-1798. hum was the number of the jira wrong? http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env.h File src/kudu/util/env.h: http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env.h@319 PS1, Line 319: RUNNING_THREADS hum, technically RLIMIT_NPROC is the limit of the total number of processes that can run for a user, not the total number of threads a process can run. yes that translates to almost the same thing when kudu is run with its own user, but wondering if conflating the two isn't confusing... -- To view, visit http://gerrit.cloudera.org:8080/9521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0 Gerrit-Change-Number: 9521 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 01:25:44 +0000 Gerrit-HasComments: Yes
