Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9573 )

Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9573/1/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:

http://gerrit.cloudera.org:8080/#/c/9573/1/src/kudu/consensus/consensus_peers.cc@230
PS1, Line 230:     VLOG_WITH_PREFIX_UNLOCKED(1) << s.ToString();
> Why is this demoted to VLOG instead of throttled? I've found this message u
All error messages from RequestForPeer() are printed (with throttle or not) 
within the RequestForPeer() method itself except for pure information message 
that a peer's queue is no longer in a leader mode, and I thought there is not 
much the reader can get out of that message anyway.


http://gerrit.cloudera.org:8080/#/c/9573/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/9573/1/src/kudu/consensus/consensus_queue.cc@652
PS1, Line 652:         KLOG_EVERY_N_SECS_THROTTLER(INFO, 60, 
peer_copy.status_log_throttler, "logs_gced")
> Also, how does this work given that the throttler here is a member of the p
Right -- that was my concern as well.  However, I saw this construct is used 
elsewhere in the code (like at line 697), so I assumed it worked somehow.  All 
right, I'll take a second look at that.


http://gerrit.cloudera.org:8080/#/c/9573/1/src/kudu/consensus/consensus_queue.cc@652
PS1, Line 652:         KLOG_EVERY_N_SECS_THROTTLER(INFO, 60, 
peer_copy.status_log_throttler, "logs_gced")
> I'm a little bit concerned about not printing this message for every peer t
I thought the peer_copy.status_log_throttler takes care of the  per-peer part, 
but maybe I was wrong.



--
To view, visit http://gerrit.cloudera.org:8080/9573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9573
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 13 Mar 2018 00:14:06 +0000
Gerrit-HasComments: Yes

Reply via email to