Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9554 )
Change subject: iwyu: workaround missing IWYU results when using Ninja ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9554/2/build-support/iwyu/iwyu_tool.py File build-support/iwyu/iwyu_tool.py: http://gerrit.cloudera.org:8080/#/c/9554/2/build-support/iwyu/iwyu_tool.py@190 PS2, Line 190: '(-isystem |-I\s*)([^/]\S+)' > but that's not a relative path, so it shouldn't match, right? Maybe I'm missing something, but I don't see how it's guaranteed that the command doesn't include absolute paths for '-I' directives. And if so, then I think the result is not what we want: >>> import os >>> import re >>> >>> def subber(m): ... return m.group(1) + os.path.abspath(os.path.join('/tmp') + m.group(2)) ... >>> re.sub(r'(-isystem |-I\s*)([^/]\S+)', subber, '-I /usr/include') '-I/tmp /usr/include' >>> So, that's not what we want, right? -- To view, visit http://gerrit.cloudera.org:8080/9554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I092cab794fd20a39fcfbbbe52f4c325fac2d149c Gerrit-Change-Number: 9554 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 00:42:33 +0000 Gerrit-HasComments: Yes
