Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9573 )

Change subject: KUDU-2322: don't spew logs about behind-log-GC follower
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

lgtm, Todd may want to take a look as well

http://gerrit.cloudera.org:8080/#/c/9573/2/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/9573/2/src/kudu/consensus/consensus_queue.cc@712
PS2, Line 712:       auto& log_throttler = *peer_copy.status_log_throttler;
nit: for code style reasons related to the google c++ style guide I would 
prefer to avoid defining the auto& temporary and just specify 
*peer_copy.status_log_throttler to the macro invocation here and above on line 
667, but I can see there is no functional difference and it seems like a grey 
area. In order to do that we would need to change the macro implementation to 
put the "throttler" variable in parentheses in logging.h line 158.



--
To view, visit http://gerrit.cloudera.org:8080/9573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4438e63aef0be26c149c57f9f58cb54327e41a33
Gerrit-Change-Number: 9573
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 13 Mar 2018 06:00:23 +0000
Gerrit-HasComments: Yes

Reply via email to