Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9510 )

Change subject: [tools] KUDU-2331: Allow move tool to work when uninvolved 
tserver is down
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9510/6/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/9510/6/src/kudu/tools/kudu-admin-test.cc@245
PS6, Line 245:   if (enable_kudu_1097 == Kudu1097::Enable) {
             :     ts_flags = master_flags = { 
Substitute("--raft_prepare_replacement_before_eviction=$0",
             :                                            enable_kudu_1097 == 
Kudu1097::Enable) };
             :   }
Woops, my point was that since the 3-4-3 became the replica management scheme 
by default, it's better to remove the 'if (enable_kudu_1097 == 
Kudu1097::Enable)' conditional.  Otherwise, as I understand, this test is not 
verifying how it works with the 3-2-3 scheme.



--
To view, visit http://gerrit.cloudera.org:8080/9510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fc60233f4f50f478da7ccb104e37df3067400c
Gerrit-Change-Number: 9510
Gerrit-PatchSet: 6
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 16:33:57 +0000
Gerrit-HasComments: Yes

Reply via email to