Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9608 )
Change subject: Remove tcmalloc_spinlock_contention metric ...................................................................... Remove tcmalloc_spinlock_contention metric Spinlock contention was removed from tcmalloc upstream, so this metric has been set to 0 since we upgraded to tcmalloc 2.6. I looked briefly at reverting its removal upstream, but the revert would be fairly large, so I think it's best to just accept the loss of this instrumentation. Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Reviewed-on: http://gerrit.cloudera.org:8080/9595 Tested-by: Todd Lipcon <t...@apache.org> Reviewed-by: Adar Dembo <a...@cloudera.com> (cherry picked from commit 4889a9156a7e1f51b076f4bc9f44621a1b2f46e4) Reviewed-on: http://gerrit.cloudera.org:8080/9608 Tested-by: Grant Henke <granthe...@gmail.com> Reviewed-by: Grant Henke <granthe...@gmail.com> --- M docs/release_notes.adoc M src/kudu/scripts/parse_metrics_log.py M src/kudu/util/spinlock_profiling-test.cc M src/kudu/util/spinlock_profiling.cc M src/kudu/util/spinlock_profiling.h M src/kudu/util/trace.h M src/kudu/util/trace_metrics.h 7 files changed, 7 insertions(+), 103 deletions(-) Approvals: Grant Henke: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/9608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.7.x Gerrit-MessageType: merged Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Gerrit-Change-Number: 9608 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>