David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9617 )

Change subject: KUDU-1704: add python client support for READ_YOUR_WRITES mode
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/client.pyx
File python/kudu/client.pyx:

http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/client.pyx@57
PS1, Line 57: ryw
best to have it expanded for consistency (i.e. s/ryw/read_your_writes)


http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scanner.py@185
PS1, Line 185: Test setting the read mode and scanning against a
             :         snapshot, latest and ryw
replace with: Test scanning in latest, snapshot and read_your_writes read modes.


http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scanner.py@199
PS1, Line 199: READ_LATEST
if using the lower/simpler case names keep using those, for consistency


http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scanner.py@216
PS1, Line 216:
extra space


http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:

http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scantoken.py@196
PS1, Line 196:  Test setting the read mode and scanning against a
             :         snapshot, latest and ryw
same


http://gerrit.cloudera.org:8080/#/c/9617/1/python/kudu/tests/test_scantoken.py@215
PS1, Line 215: READ_LATEST
same



--
To view, visit http://gerrit.cloudera.org:8080/9617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281a73ead2d606e698ff7f44ddb2cd1c78ffdd2a
Gerrit-Change-Number: 9617
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 14 Mar 2018 00:44:31 +0000
Gerrit-HasComments: Yes

Reply via email to