Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9651
to review the following change.
Change subject: KUDU-2342. consensus: use tighter bound for non-voter promotion
......................................................................
KUDU-2342. consensus: use tighter bound for non-voter promotion
This patch replaces the NON_VOTER promotion heuristic based on the
--consensus_promotion_max_wal_entries_behind gflag with a heuristic that
roughly matches the promotion criteria outlined in Diego Ongaro's
dissertation.
The approach is that we track the operation count of the last batch
successfully sent from leader to peer. If the peer is within that number
of ops of the commit index, the peer is eligible for promotion.
The aforementioned gflag has been removed.
This patch passes existing tests and did well on manual testing. I will
follow up on this patch with an automated test.
Change-Id: Iff517f01d6dc25eb15d01593dd57b7dc0dd25956
Reviewed-on: http://gerrit.cloudera.org:8080/9627
Reviewed-by: Alexey Serbin <[email protected]>
Tested-by: Kudu Jenkins
(cherry picked from commit f2479e21d5a3002ebf5b1012fde83a6cffc2db82)
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 21 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/9651/1
--
To view, visit http://gerrit.cloudera.org:8080/9651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff517f01d6dc25eb15d01593dd57b7dc0dd25956
Gerrit-Change-Number: 9651
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
