Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9552 )
Change subject: docs: update release notes and scaling guide with new thread information ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@108 PS3, Line 108: the > remove? I actually think it reads better with this 'the' in place. I'm used to talking about steady state like that (i.e. "in the steady state, ..."). http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@109 PS3, Line 109: the > remove? Upon rereading, I think this should actually be "in". So: "the number of threads used during bursts of activity (such as in Raft leader elections triggered by a node failure)". That's because the threads are being used BY the leader elections, but since I already used BY in "by a node failure", IN is a reasonable substitute. http://gerrit.cloudera.org:8080/#/c/9552/3/docs/release_notes.adoc@111 PS3, Line 111: As such, it should no longer be necessary to increase the value : of `ulimit -u` (or of /proc/sys/kernel/threads-max) in order to run a Kudu : tablet server. > maybe add somewhere "normally" or "in most cases"? Hmm, given the "hot replica" situation? I guess that's true. http://gerrit.cloudera.org:8080/#/c/9552/3/docs/scaling_guide.adoc File docs/scaling_guide.adoc: http://gerrit.cloudera.org:8080/#/c/9552/3/docs/scaling_guide.adoc@187 PS3, Line 187: load > add: "with load or data/tablet size." Hmm, I thought "load" would be generic enough that it could serve as a proxy for any of those, but in context I suppose it could be viewed as the more specific "Kudu load such as active reads/writes". Done. -- To view, visit http://gerrit.cloudera.org:8080/9552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f6a39faa572e16805e1961105140d823bd82f40 Gerrit-Change-Number: 9552 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 15 Mar 2018 22:18:01 +0000 Gerrit-HasComments: Yes
