Will Berkeley has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/9645 )
Change subject: KUDU-2303: Add KuduSchema::ToString implementation
......................................................................
KUDU-2303: Add KuduSchema::ToString implementation
This patch adds KuduSchema::ToString which calls into Schema::ToString.
This patch also changes Schema::ToString by adding primary key info to
a schema, since the primary key is part of a schema.
A stringified schema should now look like below:
Schema [
primary key (my_key1, my_key2),
my_key1[int32 NOT NULL],
my_key2[string NOT NULL],
my_float[float NULLABLE]
]
Change-Id: I43958c3733bf273c810cc77068e8d69a3fb2f132
Reviewed-on: http://gerrit.cloudera.org:8080/9645
Reviewed-by: Will Berkeley <[email protected]>
Tested-by: Will Berkeley <[email protected]>
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
5 files changed, 75 insertions(+), 1 deletion(-)
Approvals:
Will Berkeley: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I43958c3733bf273c810cc77068e8d69a3fb2f132
Gerrit-Change-Number: 9645
Gerrit-PatchSet: 10
Gerrit-Owner: Fengling Wang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Fengling Wang <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
