Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9720 )
Change subject: [master-test] TestDumpStacksOnRpcQueueOverflow is not relevant on macOS ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9720/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9720/1//COMMIT_MSG@7 PS1, Line 7: OS X > nit: s/OS X/macOS/g Done http://gerrit.cloudera.org:8080/#/c/9720/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/9720/1/src/kudu/master/master-test.cc@802 PS1, Line 802: // This test is not relevant on OS X where stack trace dumping is not supported. > nit: I'd prefer to have the comment explaining what the test is above the m Done http://gerrit.cloudera.org:8080/#/c/9720/1/src/kudu/master/master-test.cc@848 PS1, Line 848: ... > What's the purpose of the ...? That comes from the generic pattern: #ifdef X #else // #ifdef X ... #endif // #ifdef X ... #else ... However, I think it's just a redundant piece I can remove. -- To view, visit http://gerrit.cloudera.org:8080/9720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6e1424a37628537f45b6cda7fd9b7e06101e53e Gerrit-Change-Number: 9720 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 15:06:15 +0000 Gerrit-HasComments: Yes
