Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9717 )
Change subject: fs: clarify failures on non-disk-failures ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9717/1/src/kudu/tablet/tablet_replica_mm_ops.cc File src/kudu/tablet/tablet_replica_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/9717/1/src/kudu/tablet/tablet_replica_mm_ops.cc@144 PS1, Line 144: LOG(WARNING) << tablet->LogPrefix() << "failed to flush MRS: " << s.ToString(); > maybe, this is no longer needed once the information is duplicated in the C I thought about this, but my thinking was that maybe it's helpful to know when a flush has been aborted and correctly handled. From a user's perspective, it may be scary, but I think some kind of warning is appropriate, although I could be convinced otherwise. http://gerrit.cloudera.org:8080/#/c/9717/1/src/kudu/tablet/tablet_replica_mm_ops.cc@199 PS1, Line 199: LOG(WARNING) << tablet->LogPrefix() << "failed to flush DMS: " << s.ToString(); > ditto Ack -- To view, visit http://gerrit.cloudera.org:8080/9717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I062bbb69847f7da5d381281a6c24b806bafc2620 Gerrit-Change-Number: 9717 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 20 Mar 2018 21:32:43 +0000 Gerrit-HasComments: Yes
