Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9641 )
Change subject: Add a way to pin clean time advancement ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9641/3/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: http://gerrit.cloudera.org:8080/#/c/9641/3/src/kudu/tablet/mvcc-test.cc@248 PS3, Line 248: the nit: drop http://gerrit.cloudera.org:8080/#/c/9641/3/src/kudu/tablet/mvcc-test.cc@268 PS3, Line 268: advance advances http://gerrit.cloudera.org:8080/#/c/9641/3/src/kudu/tablet/mvcc-test.cc@270 PS3, Line 270: safe_time = Timestamp(55); : mgr.AdjustSafeTime(Timestamp(55)); : ASSERT_EQ(safe_time, mgr.GetCleanTimestamp()); I'm not sure this corresponds to the comment above: the transaction timestamp is Timestamp(50), right? http://gerrit.cloudera.org:8080/#/c/9641/3/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/9641/3/src/kudu/tablet/mvcc.cc@233 PS3, Line 233: std::min({earliest_in_flight_, safe_time_, clean_time_pin_}); > Does it work as expected when clean_time_pin_ == Timestamp::kInvalidTimesta Apparently, it does :) -- To view, visit http://gerrit.cloudera.org:8080/9641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If863d28016aee98672d94ec5dc8a8630e1cbf5c8 Gerrit-Change-Number: 9641 Gerrit-PatchSet: 3 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 21 Mar 2018 19:25:09 +0000 Gerrit-HasComments: Yes
