Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9752 )
Change subject: KUDU-972. Cache should track the memory overhead ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9752/1/src/kudu/cfile/block_cache-test.cc File src/kudu/cfile/block_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/9752/1/src/kudu/cfile/block_cache-test.cc@43 PS1, Line 43: MemTracker::FindTracker("block_cache-sharded_lru_cache", &mem_tracker); Could just ASSERT_TRUE() on the return result. http://gerrit.cloudera.org:8080/#/c/9752/1/src/kudu/cfile/block_cache-test.cc@66 PS1, Line 66: LOG(INFO) << "Cache overhead for one entry: " << overhead; Want to keep this around? Or was it just for debugging? http://gerrit.cloudera.org:8080/#/c/9752/1/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/9752/1/src/kudu/util/cache.h@170 PS1, Line 170: // If 'charge' is not 'kAutomaticCharge', then the cache capacity will be charged : // the explicit amount. This is useful when caching items that are small but need to : // maintain a bounded count (eg file descriptors) rather than caring about their actual : // memory usage. Right, code_cache and file_cache fall into this bucket. I take it that they're small enough (and their cached objects are small enough) that not tracking their memory overhead isn't a big deal? -- To view, visit http://gerrit.cloudera.org:8080/9752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cc69004dccb1cc372fdedbac321154e46a92263 Gerrit-Change-Number: 9752 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 22 Mar 2018 16:32:20 +0000 Gerrit-HasComments: Yes
