Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9754 )
Change subject: [itests] additional test for 3-4-3 replication ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/9754/4/src/kudu/integration-tests/raft_consensus-itest-base.h File src/kudu/integration-tests/raft_consensus-itest-base.h: http://gerrit.cloudera.org:8080/#/c/9754/4/src/kudu/integration-tests/raft_consensus-itest-base.h@46 PS4, Line 46: SHUTDOWN_RESTART, // Shutdown and then restart the affected tserver. > For some test scenarios it's crucial to keep the tablet server in shut down Just curious, is there one you had in mind? http://gerrit.cloudera.org:8080/#/c/9754/6/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/9754/6/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@2043 PS6, Line 2043: for (auto replica_type_filter: { ANY_REPLICA, VOTER_REPLICA }) { Isn't VOTER_REPLICA a subset of ANY_REPLICA? Why not just wait for a VOTER? -- To view, visit http://gerrit.cloudera.org:8080/9754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb1be6d1df751affc0fcfca5f2069eaad5888606 Gerrit-Change-Number: 9754 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 23 Mar 2018 02:23:15 +0000 Gerrit-HasComments: Yes
