Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 )
Change subject: [tools] Add a tool to recover master data from tablet servers ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/9490/4/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/9490/4/src/kudu/tools/master_rebuilder.cc@289 PS4, Line 289: // Start up the master and syscatalog. > > 1) By calling Master::Init(), do we bind to some ports? I think it's worth exploring both, but don't bother reimplementing anything yet. I'm also curious to hear what approaches other people might have. One other thing I like about #2 is that it could dovetail nicely with backup/restore metadata functionality. You can imagine master endpoints that import/export the raw metadata into a file format of some kind, and then the rebuilder is really just about "use info from the tservers to build a master metadata dump". But, I don't know whether the master's import/export should operate at the logical (DDL) level, or whether it's just a generic tablet import/export but for the singleton master tablet. -- To view, visit http://gerrit.cloudera.org:8080/9490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If29e421d466a531ebad72e281ae27e74e458f8c6 Gerrit-Change-Number: 9490 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 23 Mar 2018 18:24:29 +0000 Gerrit-HasComments: Yes
