Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 )
Change subject: KUDU-16: enable server-side limits on scanners ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9783/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9783/1//COMMIT_MSG@7 PS1, Line 7: KUDU-16: enable server-side limits on scanners Could you split the client-side portion out of this patch? You're already testing the new server-side functionality with raw scan RPCs, so there's no reason why you can't treat it as a fully encapsulated patch. http://gerrit.cloudera.org:8080/#/c/9783/1//COMMIT_MSG@19 PS1, Line 19: The existing uint64 protobuf field has been deprecated and replaced with : a new int64 field. Why? What's wrong with reusing the existing field? -- To view, visit http://gerrit.cloudera.org:8080/9783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ca5ddff09f4910d12f80259bd11e4027f99aa7c Gerrit-Change-Number: 9783 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 23 Mar 2018 18:32:08 +0000 Gerrit-HasComments: Yes
