Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9810 )
Change subject: KUDU-2377: cap GetResourceLimit return value at kint32max ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9810/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/9810/1/src/kudu/util/env_posix.cc@1591 PS1, Line 1591: return l.rlim_cur > kint32max ? kint32max : l.rlim_cur; > Should we be checking explicitly for RLIM_INFINITY here as well? The new do Looks like rlim_cur is a __uint64_t. Maybe it's worth a comment to specify that -1 and RLIM_INFINITY are effectively the same? -- To view, visit http://gerrit.cloudera.org:8080/9810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d30ebd5447867d4227974e64786cc48fdbf2688 Gerrit-Change-Number: 9810 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 01:17:22 +0000 Gerrit-HasComments: Yes
