Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 )
Change subject: KUDU-16 pt 1: add server-side limits on scanners ...................................................................... Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/scan_spec.h File src/kudu/common/scan_spec.h: http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/scan_spec.h@42 PS1, Line 42: cache_blocks_(true), > warning: initializer for member 'lower_bound_partition_key_' is redundant [ Done http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/scan_spec.h@43 PS1, Line 43: has_limit_(false), > warning: initializer for member 'exclusive_upper_bound_partition_key_' is r Done http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/scan_spec.h@172 PS1, Line 172: > It would be cleaner to use an optional<int64_t> if you don't want to specia Done http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/scan_spec.cc File src/kudu/common/scan_spec.cc: http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/scan_spec.cc@132 PS1, Line 132: const string limit = has_limit_ ? Substitute(" LIMIT $0", limit_) : ""; > nice. Ack http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/common/wire_protocol.cc@771 PS1, Line 771: for (int i = 0; i < run_size && !has_fulfilled_limit(); i++) { > You can avoid adding another runtime check in the inner loop by hoisting th Done. Slightly different impl, but along the same lines. http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tablet_server-test.cc@2102 PS1, Line 2102: const int64_t kHighLimit = kNumRows * 2; > warning: either cast from 'int' to 'const int64_t' (aka 'const long') is in Done http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tablet_server-test.cc@2107 PS1, Line 2107: int num_rows = AllowSlowTests() ? 10000 : 1000; > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tablet_service.cc@494 PS1, Line 494: limit do > s/limitted/limited Done http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/9783/1/src/kudu/tserver/tserver.proto@229 PS1, Line 229: // DEPRECATED: use column_predicates field. > Thanks for adding this. Going forward I'd be in favor of using the depreca Done -- To view, visit http://gerrit.cloudera.org:8080/9783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ca5ddff09f4910d12f80259bd11e4027f99aa7c Gerrit-Change-Number: 9783 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 27 Mar 2018 23:07:18 +0000 Gerrit-HasComments: Yes
