Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9840 )

Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9840/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9840/1//COMMIT_MSG@16
PS1, Line 16: confirmed on SLES11 that the new credential
            : is being inserted by checking the 'auth time' of the ticket
            : in ccache.
nit: Could you also add that this was found on SLES11 because Impala has a 
slightly different ifdef which exercised that path on SLES11?
https://github.com/apache/impala/blob/6f2ebadf8d119b1486f54b911ba3c7ecc1921d55/be/src/kudu/security/init.cc#L344-L352



--
To view, visit http://gerrit.cloudera.org:8080/9840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c
Gerrit-Change-Number: 9840
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Comment-Date: Wed, 28 Mar 2018 18:13:44 +0000
Gerrit-HasComments: Yes

Reply via email to