Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9760 )
Change subject: meta_cache: improve multi-threaded scalability ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9760/1/src/kudu/util/locks.h File src/kudu/util/locks.h: http://gerrit.cloudera.org:8080/#/c/9760/1/src/kudu/util/locks.h@142 PS1, Line 142: // This means that in the read-mostly case, different readers will not cause any : // cacheline contention. : // : // Usage: : // percpu_rwlock mylock; : // : // // Lock shared: : // { : // boost::shared_lock<rw_spinlock> lock(mylock.get_lock()); : // ... : // } : // : // // Lock exclusive: : // : // { > Mind updating this with the lock guards we actually use now? I think you missed this one. -- To view, visit http://gerrit.cloudera.org:8080/9760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38c8a94ea177bfa4f4e2048355464f76a5daa2ba Gerrit-Change-Number: 9760 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 29 Mar 2018 02:10:22 +0000 Gerrit-HasComments: Yes
