Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9852 )
Change subject: [examples] Improve the basic Java example ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9852/1/examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java File examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java: http://gerrit.cloudera.org:8080/#/c/9852/1/examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java@89 PS1, Line 89: KuduSession session = client.newSession(); I wonder if it'd be useful to demonstrate or at least draw some attention to setting the flush mode. WDYT? It might seem a bit in the weeds, but it seems like one of a few client-knobs/levers not already included in this example, and maybe we should at least call out all of basic the knobs/levers. In the same spirit, maybe also make one of the columns nullable? And add hash partitioning? As a developer looking for a quick how-to without e.g. digging through API docs or source code, getting a taste for all the things in one example seems like it'd be super convenient, at the cost of a few more lines. -- To view, visit http://gerrit.cloudera.org:8080/9852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ab5b0b2c30e8fd7c799857a0e3754b7618a580 Gerrit-Change-Number: 9852 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 29 Mar 2018 23:40:19 +0000 Gerrit-HasComments: Yes
