Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9853 )
Change subject: [examples] Improve loadgen example ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9853/1/examples/java/insert-loadgen/README.adoc File examples/java/insert-loadgen/README.adoc: http://gerrit.cloudera.org:8080/#/c/9853/1/examples/java/insert-loadgen/README.adoc@45 PS1, Line 45: create-demo-table This doesn't exist anymore. http://gerrit.cloudera.org:8080/#/c/9853/1/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java File examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java: http://gerrit.cloudera.org:8080/#/c/9853/1/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java@126 PS1, Line 126: session.flush(); Hmm, if we're using AUTO_FLUSH_BACKGROUND why do we need this explicit flush? -- To view, visit http://gerrit.cloudera.org:8080/9853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0e655f56adcedec2c3dd8a8b3c900e3b2e7803 Gerrit-Change-Number: 9853 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 00:01:13 +0000 Gerrit-HasComments: Yes
