Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9888 )
Change subject: Followup to bae6170c77 to fix build on macos ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h File src/kudu/util/env.h: http://gerrit.cloudera.org:8080/#/c/9888/2/src/kudu/util/env.h@322 PS2, Line 322: If there is : // no limit, returns RLIM_INFINITY which is guaranteed to be positive. > Hmm, but we don't want to leak RLIM_INFINITY outside env; it's an implement Alternatively, maybe we can just remove this sentence? AFAICT callers can completely ignore that there is such thing as no limit or RLIM_INFINITY. They can just treat the return value as the true limit. -- To view, visit http://gerrit.cloudera.org:8080/9888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13780d86d4a286710c1bcf8a5f4266fb7fe162c7 Gerrit-Change-Number: 9888 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 02 Apr 2018 18:58:49 +0000 Gerrit-HasComments: Yes
