Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9896 )
Change subject: pprof: fix contention output ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Small nit http://gerrit.cloudera.org:8080/#/c/9896/1/src/kudu/server/pprof_path_handlers.cc File src/kudu/server/pprof_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/9896/1/src/kudu/server/pprof_path_handlers.cc@169 PS1, Line 169: ostringstream* output = resp->output; nit: maybe move this down where it's used. Its current placement is an artifact of the pre-600723e0e954a1b199e6a0bf1dfd63fe7289a6a8 implementation. Putting it down by L184 might make it more obvious we should be using `output` instead of `profile`. http://gerrit.cloudera.org:8080/#/c/9896/1/src/kudu/server/pprof_path_handlers.cc@195 PS1, Line 195: Env::Default() :-/ -- To view, visit http://gerrit.cloudera.org:8080/9896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b55a47c3e23daa62302b4318580592695ec0f5f Gerrit-Change-Number: 9896 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 03 Apr 2018 02:12:32 +0000 Gerrit-HasComments: Yes
