Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 )
Change subject: KUDU-16: remove Java warnings wrt scanner limits ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9926/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/9926/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@504 PS1, Line 504: int limits[] = { num_rows - 1, num_rows, num_rows + 1 }; Can you add 0 here? What happens if there is a negative value? -- To view, visit http://gerrit.cloudera.org:8080/9926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83635fbbc7714318f8b95d91b7f178e9ca7ebff7 Gerrit-Change-Number: 9926 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 04 Apr 2018 19:57:01 +0000 Gerrit-HasComments: Yes
