Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9931 )
Change subject: WIP: use ExternalProject_Add to define thirdparty deps ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9931/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9931/1/CMakeLists.txt@836 PS1, Line 836: if(${LIB_NAME} STREQUAL "snappy") > This was just a hack I used for the POC, but we will need logic to establis Makes sense. That might also allow us to have separate ExternalProject targets for 'foolib' and 'foolib-tsan', right? -- To view, visit http://gerrit.cloudera.org:8080/9931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dec48958bf09f8f1a0d8af08c815a22d8240c3d Gerrit-Change-Number: 9931 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 17:54:48 +0000 Gerrit-HasComments: Yes
