Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9882 )
Change subject: [tools] ksck improvements [2/n]: KUDU-2306: ksck master health check ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9882/3/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/9882/3/src/kudu/tools/ksck.h@240 PS3, Line 240: enum class KsckFetchState { : // Information has not yet been fetched. : UNINITIALIZED, : // The attempt to fetch information failed. : FETCH_FAILED, : // Infor > Right, but does it matter whether we're FETCH_FAILED vs UNINITIALIZED? It s Yeah, UNINITIALIZED v FETCH_FAILED is useful for preconditions to check for programmer error. It's not a meaningful distinction for the ksck checks. -- To view, visit http://gerrit.cloudera.org:8080/9882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0066468a0adc563979dcd2c61cd65d66978420c Gerrit-Change-Number: 9882 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 21:04:31 +0000 Gerrit-HasComments: Yes
