Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9944 )
Change subject: test_util: reset flags before cleaning test directory ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9944/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/9944/1/src/kudu/fs/fs_manager-test.cc@633 PS1, Line 633: { : FLAGS_crash_on_eio = false; : FLAGS_env_inject_eio = 1.0; : FLAGS_env_inject_eio_globs = JoinPathSegments(new_path2, "**"); : : const string new_path3 = GetTestPath("new_path3"); : opts.data_roots = { fs_root_, new_path2, new_path3 }; : ReinitFsManagerWithOpts(opts); : Status s = fs_manager()->Open(); : ASSERT_TRUE(s.IsIOError()); : ASSERT_STR_CONTAINS(s.ToString(), "found failed data directory"); : } nit: this no longer needs to be scoped, right? -- To view, visit http://gerrit.cloudera.org:8080/9944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b4843cbc2c3bc2cbeb3a4d5959f80a35da7714a Gerrit-Change-Number: 9944 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Apr 2018 19:17:15 +0000 Gerrit-HasComments: Yes
