Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9452 )

Change subject: KUDU-2293 fix cleanup after failed copies
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9452/10/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

http://gerrit.cloudera.org:8080/#/c/9452/10/src/kudu/tserver/ts_tablet_manager.cc@607
PS10, Line 607:           Status s = DeleteTabletData(meta, cmeta_manager_, 
TABLET_DATA_TOMBSTONED,
> Yeah, I wouldn't be opposed to removing this; wasn't sure how to best remov
We're not doing that revert, but we hypothetically could do that if we wanted 
it to be "atomic". I just don't think it really make sense because we could 
have already deleted some blocks or something like that.

My point is that once we try to DeleteData() then I think we are stuck leaving 
the metadata in whatever tablet data state we specified there, regardless of 
what make it to disk or not. Try to provide a "cleaner" guarantee for the API 
would be a path to madness. :)



--
To view, visit http://gerrit.cloudera.org:8080/9452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0459d484a3064aa2de392328e2910c9f6741be04
Gerrit-Change-Number: 9452
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sat, 07 Apr 2018 01:44:43 +0000
Gerrit-HasComments: Yes

Reply via email to