Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9948 )

Change subject:  Add GetFlags endpoint and tool
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9948/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9948/2//COMMIT_MSG@12
PS2, Line 12:  It
            : supports returning all flags, and also filtering flags by tags.
> How difficult would it be to also filter by name via regex or something? Do
Not so hard, but there's no use case for it now. Mike and I talked about it and 
had two use cases:
- Quickly checking for non-default values from the cmd line.
- ksck checking for non-default values of safe, hidden, experimental flags

The default behavior + tags filtering fulfills those two cases. If somebody 
wants to filter by more advanced criteria they can filter the full response 
with all flags client-side, and if it becomes a significant use case that 
filtering could be added server-side later.


http://gerrit.cloudera.org:8080/#/c/9948/2/src/kudu/server/generic_service.cc
File src/kudu/server/generic_service.cc:

http://gerrit.cloudera.org:8080/#/c/9948/2/src/kudu/server/generic_service.cc@20
PS2, Line 20: #include <string>
> warning: #includes are not sorted properly [llvm-include-order]
Done



--
To view, visit http://gerrit.cloudera.org:8080/9948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia35b4261099c1a3c6e2ff68e907c84df9a7ff699
Gerrit-Change-Number: 9948
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Sat, 07 Apr 2018 18:37:51 +0000
Gerrit-HasComments: Yes

Reply via email to