Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9948

to look at the new patch set (#3).

Change subject:  Add GetFlags endpoint and tool
......................................................................

Add GetFlags endpoint and tool

This adds an rpc endpoint that retrieves gflags from servers.

It also includes a tool for retrieving flag values from servers.
By default, it returns only flags with non-default values. It
supports returning all flags, and also filtering flags by tags.

Example output from the tool run against a local cluster's master:

          flag          |                     value                     | 
default? |      tags
------------------------+-----------------------------------------------+----------+-----------------
 log_dir                | /tmp/kudu/logs/master/0                       | false 
   | stable
 heap_profile_path      | /tmp/kudu-master.56285                        | false 
   | advanced,stable
 log_filename           | kudu-master                                   | false 
   | stable
 webserver_interface    | 127.0.0.1                                     | false 
   | advanced
 master_addresses       | 127.0.0.1:7053,127.0.0.1:7052,127.0.0.1:7051, | false 
   | stable
 fs_data_dirs           | /tmp/kudu/data/master/0/0                     | false 
   | stable
 rpc_bind_addresses     | 127.0.0.1:7051                                | false 
   | stable
 fs_wal_dir             | /tmp/kudu/wal/master/0                        | false 
   | stable
 evict_failed_followers | false                                         | false 
   | advanced
 webserver_port         | 8051                                          | false 
   | stable

The rpc endpoint will also be used by ksck in a follow-up.

Change-Id: Ia35b4261099c1a3c6e2ff68e907c84df9a7ff699
---
M src/kudu/server/generic_service.cc
M src/kudu/server/generic_service.h
M src/kudu/server/server_base.proto
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
11 files changed, 276 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/9948/3
--
To view, visit http://gerrit.cloudera.org:8080/9948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia35b4261099c1a3c6e2ff68e907c84df9a7ff699
Gerrit-Change-Number: 9948
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>

Reply via email to