Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9912 )

Change subject: [tools] ksck improvements [4/n]: KUDU-2271 and KUDU-2310
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9912/2/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

http://gerrit.cloudera.org:8080/#/c/9912/2/src/kudu/tools/ksck.cc@529
PS2, Line 529:  const string tables_or_tablets = tablet_id_filters_.empty() ? 
"tables" : "tablets";
could maybe be used throughout this function? Although I guess in all the 
places you have to branch anyway, so maybe not.



--
To view, visit http://gerrit.cloudera.org:8080/9912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2371b704a7c2ebb1b5a4822e3b4d852443c200c5
Gerrit-Change-Number: 9912
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Mon, 09 Apr 2018 19:37:38 +0000
Gerrit-HasComments: Yes

Reply via email to